Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style disabled state of inputs #2292 #2296

Closed
wants to merge 2 commits into from
Closed

Style disabled state of inputs #2292 #2296

wants to merge 2 commits into from

Conversation

Pratik-A-N
Copy link
Contributor

I have made the changes in the inputNode component className prop which had classNames function in which I added the extra condition to check whether the field is disabled or not and applied the styles as desired in the issue discription

Linking this PR to an issue

Fixes _#2292

Type of change

  • fix: Bug fix (non-breaking change which fixes an issue)

Screenshots of the changes [optional]

Screenshot from 2023-03-31 07-16-29

How has this been tested?

The Public Key field can be now checked and it is according to the required UI which reflects that it is disabled in both light and dark modes. It can be seen in the below images.

Screenshot from 2023-03-31 07-19-44
Screenshot from 2023-03-31 07-20-11

Checklist

  • My code follows the style guidelines of this project and performed a self-review of my own code
  • New and existing tests pass locally with my changes
  • I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎

🚨 Potential security issues found in this pull request. To accept the risk, merge this PR and you will not be notified again.

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore msw@1.2.1
  • @SocketSecurity ignore core-js-pure@3.29.1
  • @SocketSecurity ignore node@18.14.0
📜 Install scripts

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Package Script field Source
msw@1.2.1 (upgraded) postinstall package.json
core-js-pure@3.29.1 (upgraded) postinstall package.json via pptr-testing-library@0.7.0
node@18.14.0 (added) preinstall package-lock.json, package.json
Pull request alert summary
Issue Status
Install scripts ⚠️ 3 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
node@18.14.0 filesystem, shell, environment +1 aredridel
⬆️ Updated Package Version Diff Capability Access +/- Transitive Count Publisher
msw@1.2.1 1.1.0...1.2.1 eval, network, filesystem, shell, environment +24/-35 kettanaito
postcss-loader@7.1.0 7.0.2...7.1.0 eval, filesystem, environment +4/-47 evilebottnawi
bolt11@1.4.1 1.4.0...1.4.1 eval, filesystem, shell, environment +5/-6 junderw
eslint-config-prettier@8.8.0 8.7.0...8.8.0 None +0/-30 lydell
sass-loader@13.2.2 13.2.0...13.2.2 environment +1/-47 evilebottnawi
react-toastify@9.1.2 9.1.1...9.1.2 filesystem, environment +1/-1 sniphpet
webpack-dev-server@4.13.1 4.11.1...4.13.1 eval, network, filesystem, shell, environment +42/-79 evilebottnawi
react-router-dom@6.10.0 6.8.2...6.10.0 network, filesystem, environment +2/-2 mjackson
mini-css-extract-plugin@2.7.5 2.7.3...2.7.5 eval +2/-43 evilebottnawi
@headlessui/react@1.7.13 1.7.12...1.7.13 filesystem, environment +0/-0 malfaitrobin
@playwright/test@1.32.1 1.31.1...1.32.1 eval, network, filesystem, shell, environment +1/-2 aslushnikov
i18next@22.4.13 22.4.10...22.4.13 None +1/-1 adrai
@typescript-eslint/parser@5.57.0 5.54.1...5.57.0 filesystem, environment +3/-35 jameshenry
@typescript-eslint/eslint-plugin@5.57.0 5.54.1...5.57.0 filesystem, environment +7/-38 jameshenry

🚮 Removed packages: @commitlint/cli@17.4.4, @swc/core@1.3.35, eslint@8.35.0, prettier@2.8.4, puppeteer@19.7.2, sass@1.58.3, tailwindcss@3.2.7, webpack@5.76.1

@Pratik-A-N Pratik-A-N closed this Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Pratik-A-N